Skip to content

ci: remove old_name now that pipelines are configured#669

Merged
aramprice merged 1 commit into
ubuntu-jammyfrom
remove-old_name
Jun 23, 2026
Merged

ci: remove old_name now that pipelines are configured#669
aramprice merged 1 commit into
ubuntu-jammyfrom
remove-old_name

Conversation

@aramprice

@aramprice aramprice commented Jun 23, 2026

Copy link
Copy Markdown
Member

NOTE: this repository uses a "Merge Forward" strategy

Changes should be made in the earliest applicable branch, and
merged forward through subsequent branches.

  1. PR should be created against the oldest stemcell branch, ex: ubuntu-<short_name-N>
  2. After this PR has been merged create a PR to merge ubuntu-<short_name-N> into ubuntu-<short_name-N+1>
  3. Repeat as needed for subsequent stemcell line branches

Copilot AI review requested due to automatic review settings June 23, 2026 00:31
Copilot AI reviewed Jun 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 36b5d387-1e9b-4059-8cb6-91dd22121e0a

📥 Commits

Reviewing files that changed from the base of the PR and between 7d91bba and 5e58ebb.

📒 Files selected for processing (1)
  • ci/pipeline-template.yml
💤 Files with no reviewable changes (1)
  • ci/pipeline-template.yml

Walkthrough

Two Concourse job names in ci/pipeline-template.yml are renamed. The AWS light stemcell job changes from build-light-aws-<os>-<major> to create-light-aws-<os>-<major> (line 1008–1009), and the Google light stemcell job changes from build-light-google-<os>-<major> to create-light-google-<os>-<major> (line 1097–1098). The template parameters and job plan structures are unchanged in both cases.

Suggested Reviewers

  • mkocher
  • julian-hj
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions removing old_name but the actual change involves renaming light stemcell job names, which is unrelated to removing configuration parameters. Update the title to accurately reflect the main change: something like 'ci: rename light stemcell jobs from build to create' would better represent the actual modifications.
Description check ⚠️ Warning The description only contains the merge-forward strategy template without explaining the specific changes made in this PR regarding job renames. Add a section explaining what is being changed (job name updates from 'build-light-' to 'create-light-') and why this change is necessary.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-old_name

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@aramprice aramprice requested review from a team, s4heid and ystros and removed request for a team June 23, 2026 00:32
@aramprice aramprice merged commit 1f02d8d into ubuntu-jammy Jun 23, 2026
12 checks passed
@aramprice aramprice deleted the remove-old_name branch June 23, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

@ystros ystros Awaiting requested review from ystros ystros was automatically assigned from cloudfoundry/wg-foundational-infrastructure-vm-deployment-lifecycle-bosh-approvers

@s4heid s4heid Awaiting requested review from s4heid s4heid was automatically assigned from cloudfoundry/wg-foundational-infrastructure-vm-deployment-lifecycle-bosh-approvers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aramprice